ESQL: Support tags in LuceneCountOperator
#133479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for "tagged queries" to the `LuceneCountOperator`. `LuceneCountOperator` is the Lucene native implementation for queries like: ``` FROM foo | STATS COUNT(*) ``` This is something we can often implement very quickly using Lucene's statistics. It's also used for: ``` FROM foo | WHERE a > 10 | STATS COUNT(*) ``` Here we can't use statistics, but Lucene's queries have `count` methods on them that *can* be very very fast because they use pre-calculated statistics. For example, the filter cache stores the number of hits and `count` method runs in O(1) time. And we need this Operator to use it. "Tagged queries" support means we should be able to use this same operator for cases like: ``` FROM foo | STATS COUNT(*) BY DATE_TRUNC(1 DAY, @timestamp) ``` This doesn't plug that in to the query planner, but we should be able to do so after this PR. Which would bring us to parity with agg ala: https://www.elastic.co/blog/how-we-made-date-histogram-aggregations-faster-than-ever-in-elasticsearch-7-11
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Aug 25, 2025
|
|
||
| /** Returns a deep copy of the given block, using the blockFactory for creating the copy block. */ | ||
| public static Block deepCopyOf(Block block, BlockFactory blockFactory) { | ||
| // TODO preserve constants here. |
There was a problem hiding this comment.
I'm going to do this now.
dnhatn
approved these changes
Aug 26, 2025
| } | ||
| } | ||
|
|
||
| private List<ElementType> tagTypes; |
There was a problem hiding this comment.
nit: final for tagTypes and tagsToState?
| } | ||
|
|
||
| private Page buildNonConstantBlocksResult() { | ||
| BlockUtils.BuilderWrapper[] builders = new BlockUtils.BuilderWrapper[1 + tagTypes.size()]; |
There was a problem hiding this comment.
I think this should be tagTypes.size() instead of 1 + tagTypes.size()?
|
Now that #133510 is in I'm going to update the test using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for "tagged queries" to the
LuceneCountOperator.LuceneCountOperatoris the Lucene native implementation for queries like:This is something we can often implement very quickly using Lucene's statistics. It's also used for:
Here we can't use statistics, but Lucene's queries have
countmethods on them that can be very very fast because they use pre-calculated statistics. For example, the filter cache stores the number of hits andcountmethod runs in O(1) time. And we need this Operator to use it."Tagged queries" support means we should be able to use this same operator for cases like:
This doesn't plug that in to the query planner, but we should be able to do so after this PR. Which would bring us to parity with agg ala: https://www.elastic.co/blog/how-we-made-date-histogram-aggregations-faster-than-ever-in-elasticsearch-7-11